Updated checkstate to support healthcheck disabling via file#579
Open
Skypex wants to merge 1 commit intosplunk:developfrom
Open
Updated checkstate to support healthcheck disabling via file#579Skypex wants to merge 1 commit intosplunk:developfrom
Skypex wants to merge 1 commit intosplunk:developfrom
Conversation
Contributor
Author
|
Hi @adityapinglesf, what new values? There are no new values, I simply added a check for a specific file. That way you can disable the health check by creating the file. Some scenarios I could think of:
Hope that answers your questions and helps evaluating this PR. |
|
yep, could be great feature. currently to debug things if shit hits the fan its close to impossible to debug, try to fix, collect diag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear maintainers,
in usual environments that run the
checkstate.sh(like Kubernetes) containers are immutable.That means that you cannot simply inject an env variable into the container without restarting the actual container.
However, due to the nature of Splunk it might be needed to perform some maintenance tasks that require a
splunkd stop.This means you need to restart the container first to add the env variable,do your thing and afterwards you need to restart the container again to remove the env variable. So in this case the healthcheck actually decreases availability.
Therefore I would kindly request to add a file check as well. That way you can disable the healthcheck in a running container temporary by creating the file and with out any additional container restarts.
Indeed the env variable method is also an option - nothing changes there.
Pleas consider merging or let me know if you need any additional changes!